Fix: Don't reset contractual base on production entities #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanib
force-pushed
the
feature/1343_fix-contractual_base_request
branch
2 times, most recently
from
658486e to
44e7425
Compare
MKodde
requested changes
Jan 15, 2025
tests/integration/Application/CommandHandler/Entity/EntityChangeRequestCommandHandlerTest.php
Outdated
Show resolved
Hide resolved
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2024 SURFnet B.V. |
There was a problem hiding this comment.
Suggested change
| * Copyright 2024 SURFnet B.V. | |
| * Copyright 2025 SURFnet B.V. |
Prior to this change, when a change request was sent, the contractualBase would be set to null, because it is not present in the form. This change updates the contractual base if necessary on update. The expected behaviour is: When the field is not present, add it with the correct value When the field is present and the value is incorrect update it When the field is present and the value is correct, leave it untouched Resolves #1343
johanib
force-pushed
the
feature/1343_fix-contractual_base_request
branch
from
44e7425 to
0085f9a
Compare
MKodde
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when a change request was sent, the contractualBase would be set to null, because it is not present in the form. This change updates the contractualbase if necessary on update.
The expected behaviour is:
When the field is not present, add it with the correct value
When the field is present and the value is incorrect update it
When the field is present and the value is correct, leave it untouched
Resolves #1343