Skip to content

Commit

Permalink
hotfix [#81] ArtistResolver 수동으로 매핑하는 방법으로 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
@ch1hyun
ch1hyun committed Jan 17, 2025
1 parent dc27e72 commit 8687069
Show file tree
Hide file tree
Showing 2 changed files with 72 additions and 122 deletions.
2 changes: 1 addition & 1 deletion src/main/java/org/sopt/confeti/domain/festival/Festival.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public class Festival {
private String price;

@OneToMany(mappedBy = "festival", cascade = CascadeType.ALL, orphanRemoval = true)
private List<FestivalDate> dates= new ArrayList<>();
private List<FestivalDate> dates = new ArrayList<>();

@OneToMany(mappedBy = "festival", cascade = CascadeType.REMOVE)
private List<FestivalFavorite> festivalFavorites = new ArrayList<>();
Expand Down
192 changes: 71 additions & 121 deletions src/main/java/org/sopt/confeti/global/util/artistsearcher/ArtistResolver.java
View file
Original file line number Diff line number Diff line change
@@ -1,76 +1,54 @@
package org.sopt.confeti.global.util.artistsearcher;

import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import lombok.AccessLevel;
import lombok.RequiredArgsConstructor;
import org.sopt.confeti.annotation.Resolver;
import org.sopt.confeti.domain.artistfavorite.ArtistFavorite;
import org.sopt.confeti.domain.concert.Concert;
import org.sopt.confeti.domain.festival.Festival;
import org.sopt.confeti.domain.festivaldate.FestivalDate;
import org.sopt.confeti.global.util.IntegrateFunction;
import org.springframework.aop.support.AopUtils;

@Resolver
@RequiredArgsConstructor(access = AccessLevel.PROTECTED)
public class ArtistResolver {

private static final boolean ACCESS_ALLOW = true;

private final Set<Class<?>> noCustomReferenceTypes = new LinkedHashSet<Class<?>>(
Arrays.asList(
Integer.class, Long.class, Float.class, Double.class,
LocalDate.class, LocalDateTime.class, LocalTime.class,
String.class
)
);

private final ConcurrentHashMap<Class<?>, IntegrateFunction> collectByTypeMapper = new ConcurrentHashMap<Class<?>, IntegrateFunction>() {{
put(ArrayList.class, args -> {
if (!(args[0] instanceof List)) {
// TODO:
// 예외 처리 추가
throw new RuntimeException();
}

collectByListType((List<?>) args[0]);
put(ArtistFavorite.class, args -> {
collectArtistFavorite(args[0]);
return null;
});
put(Concert.class, args -> {
collectConcert(args[0]);
return null;
});
put(Festival.class, args -> {
collectFestival(args[0]);
return null;
});
put(List.class, args -> {
if (!(args[0] instanceof List)) {
// TODO:
// 예외 처리 추가
throw new RuntimeException();
}

collectByListType((List<?>) args[0]);
put(FestivalDate.class, args -> {
collectFestivalDate(args[0]);
return null;
});
}};

private List<String> artistIds;
private HashMap<String, ConfetiArtist> artistMapper;
private HashMap<Object, Boolean> objectTrack;

private final SpotifyAPIHandler spotifyAPIHandler;

private void prologue() {
artistIds = new ArrayList<>();
artistMapper = new HashMap<>();
objectTrack = new HashMap<>();
}

private void epilogue() {
artistIds.clear();
artistMapper.clear();
objectTrack.clear();
}

// Spotify API를 사용해 아티스트를 로드하는 엔트리 포인트
Expand All @@ -84,111 +62,83 @@ public void load(final Object target) {
epilogue();
}

private void injection(final List<ConfetiArtist> confetiArtists) {
confetiArtists.forEach((confetiArtist -> {
ConfetiArtist mappedConfetiArtist = artistMapper.get(confetiArtist.getArtistId());
mappedConfetiArtist.setName(confetiArtist.getName());
mappedConfetiArtist.setProfileUrl(confetiArtist.getProfileUrl());
}));
}

private List<ConfetiArtist> searchByArtistIds(final List<String> artistIds) {
return spotifyAPIHandler.findArtistsByArtistIds(artistIds);
}

// 리플렉션을 사용해 타겟 오브젝트를 재귀적으로 순회하며 아티스트 아이디를 수집하는 함수
// TODO: 추후에 메소드 분리 리펙토링 예정
private void collect(final Object target) {
// 이미 탐색한 객체인 경우
if (target == null || objectTrack.containsKey(target)) {
if (target == null) {
return;
}

// 오브젝트 트랙에 현재 탐색 대상 객체를 추가
objectTrack.put(target, true);
if (isListType(target)) {
List<Object> objects = (List<Object>) target;

// 현재 오브젝트가 ConfetiArtist 타입인 경우
if (isConfetiArtistClass(target)) {
ConfetiArtist artist = (ConfetiArtist) target;
objects.forEach(object -> {
if (collectByTypeMapper.containsKey(object.getClass())) {
collectByTypeMapper.get(object.getClass())
.apply(object);
}
});

artistIds.add(artist.getArtistId());
artistMapper.put(artist.getArtistId(), artist);
return;
} else if (collectByTypeMapper.containsKey(target.getClass())) {
// 현재 오브젝트가 정해진 처리 방법이 필요한 타입인 경우 (현재는 List)
collectByTypeMapper.get(target.getClass()).apply(
target
);
return;
}

// 필드에 있는 객체 목록 확인
Class<?> targetClass = target.getClass();
Arrays.stream(targetClass.getDeclaredFields()).forEach((Field field) -> {
if (isReferenceType(field) && isNoCustomReferenceType(field)) {
if (isConfetiArtistClass(field)) {
ConfetiArtist artist = extractConfetiArtist(target, field);

artistIds.add(artist.getArtistId());
artistMapper.put(artist.getArtistId(), artist);
return;
}

setAccessibleIfPrivateOrProtected(field);

try {
if (collectByTypeMapper.containsKey(field.getType())) {
collectByTypeMapper.get(field.getType()).apply(
field.get(target)
);

return;
}

collect(field.get(target));
} catch (IllegalAccessException e) {
throw new RuntimeException(e);
}
}
});
if (collectByTypeMapper.containsKey(target.getClass())) {
collectByTypeMapper.get(target.getClass()).apply(target);
}
}

private void collectByListType(final List<?> objects) {
objects.forEach(this::collect);
private boolean isListType(final Object target) {
return target.getClass() == ArrayList.class;
}

private void setAccessibleIfPrivateOrProtected(final Field field) {
if (
Modifier.isPrivate(field.getModifiers()) || Modifier.isProtected(field.getModifiers())
) {
field.setAccessible(ACCESS_ALLOW);
}
private void collectArtistFavorite(final Object target) {
ArtistFavorite artistFavorite = (ArtistFavorite) target;
ConfetiArtist confetiArtist = artistFavorite.getArtist();
artistIds.add(confetiArtist.getArtistId());
artistMapper.put(confetiArtist.getArtistId(), artistFavorite.getArtist());
}

private boolean isNoCustomReferenceType(final Field field) {
return !noCustomReferenceTypes.contains(field.getType());
private void collectConcert(final Object target) {
Concert concert = (Concert) target;
concert.getArtists().forEach(artist -> {
artistIds.add(artist.getArtist().getArtistId());
artistMapper.put(
artist.getArtist().getArtistId(),
artist.getArtist()
);
});
}

private boolean isReferenceType(final Field field) {
return !field.getType().isPrimitive();
private void collectFestival(final Object target) {
Festival festival = (Festival) target;
festival.getDates().stream()
.flatMap(date -> date.getStages().stream())
.flatMap(stage -> stage.getTimes().stream())
.flatMap(time -> time.getArtists().stream())
.forEach(artist -> {
artistIds.add(artist.getArtist().getName());
artistMapper.put(artist.getArtist().getArtistId(), artist.getArtist());
});
}

private boolean isConfetiArtistClass(final Field field) {
return field.getType().isAssignableFrom(ConfetiArtist.class);
private void collectFestivalDate(final Object target) {
FestivalDate festivalDate = (FestivalDate) target;
festivalDate.getStages().stream()
.flatMap(stage -> stage.getTimes().stream())
.flatMap(time -> time.getArtists().stream())
.forEach(artist -> {
artistIds.add(artist.getArtist().getName());
artistMapper.put(artist.getArtist().getArtistId(), artist.getArtist());
});
}

private boolean isConfetiArtistClass(final Object object) {
return object.getClass().isAssignableFrom(ConfetiArtist.class);
private void injection(final List<ConfetiArtist> confetiArtists) {
confetiArtists.forEach((confetiArtist -> {
ConfetiArtist mappedConfetiArtist = artistMapper.get(confetiArtist.getArtistId());
mappedConfetiArtist.setName(confetiArtist.getName());
mappedConfetiArtist.setProfileUrl(confetiArtist.getProfileUrl());
}));
}

private ConfetiArtist extractConfetiArtist(final Object target, final Field field)
throws RuntimeException {
try {
setAccessibleIfPrivateOrProtected(field);
return (ConfetiArtist) field.get(target);
} catch (IllegalAccessException e) {
throw new RuntimeException();
}

private List<ConfetiArtist> searchByArtistIds(final List<String> artistIds) {
return spotifyAPIHandler.findArtistsByArtistIds(artistIds);
}
}

0 comments on commit 8687069

Please sign in to comment.