[Feat/#15] selector components #20
Merged
+349
โ0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
โฆo feat/#15-selector-component # Conflicts: # app/src/main/java/org/memento/domain/type/SelectorType.kt # app/src/main/java/org/memento/presentation/MementoTimeDateSelector.kt
imtaejugkim
approved these changes
Jan 14, 2025
app/src/main/java/org/memento/presentation/MementoChipSelector.kt
Outdated
Show resolved
Hide resolved
hyoeunjoo
reviewed
Jan 14, 2025
| ) { | ||
| Image( | ||
| imageVector = ImageVector.vectorResource(id = R.drawable.ic_deadline), | ||
| contentDescription = "Deadline Icon", |
There was a problem hiding this comment.
p2:์ด ๋ถ๋ถ ์คํธ๋ง ์ถ์ถ!
hyoeunjoo
reviewed
Jan 14, 2025
| @@ -51,7 +51,7 @@ fun MementoChipSelector( | |||
| when (selectorType) { | |||
| SelectorType.TIMESELECTOR -> { | |||
| Text( | |||
| text = "00:00 AM", | |||
| text = R.string.time_example.toString(), | |||
There was a problem hiding this comment.
p3:
contentDescription = stringResource(id = R.string.tag_icon),
์ด๋ ๊ฒ์ฐ๋ฉด ๋ค์ toString์๋ถ์ฌ๋ ๋์
hyoeunjoo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
โ ๐๐ต๐ฒ๐ฐ๐ธ-๐๐ถ๐๐
๐ ๐๐๐๐๐ฒ๐
๐๐ช๐ผ๐ฟ๐ธ ๐๐ฒ๐๐ฐ๐ฟ๐ถ๐ฝ๐๐ถ๐ผ๐ป
๐ท ๐ฆ๐ฐ๐ฟ๐ฒ๐ฒ๐ป๐๐ต๐ผ๐
2025-01-14.10.16.55.mov
๐ฌ ๐ง๐ผ ๐ฅ๐ฒ๐๐ถ๐ฒ๐๐ฒ๐ฟ๐
์ฌ์ํ ๊ฒ ๋ชจ๋ ์ฝ๋ฆฌ ๋ฌ์์ฃผ์๋ฉด ๋ฐ๋ก ์์ ํ๊ฒ ์ต๋๋ค
์ ๋ง๋ก... ๋ ์นด๋กญ๊ฒ ํด์ฃผ์ ๋ ๋ผ์ฌ.
๋ฉ๋ฅ์ด๋ค ๊ณ ๋ง์ก!!!