fix: SAML login redirects to incorrect room when using an invite #34959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dionisio-bot[bot]](https://avatars.githubusercontent.com/in/257776?s=60&v=4){kind=small}
) Co-authored-by: Kevin Aleman <[email protected]>
Co-authored-by: Lucas Pelegrino <[email protected]>
🦋 Changeset detectedLatest commit: 6a2cc9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34959 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 2820 2820
Lines 67917 67909 -8
Branches 15100 15097 -3
=======================================
- Hits 40262 40258 -4
+ Misses 24830 24829 -1
+ Partials 2825 2822 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
previously approved these changes
Jan 17, 2025
sampaiodiego
dismissed
matheusbsilva137’s stale review
The merge-base changed after approval.
sampaiodiego
force-pushed
the
release-7.2.1
branch
2 times, most recently
from
029ad16 to
abf88f4
Compare
dougfabris
approved these changes
Jan 17, 2025
matheusbsilva137
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
matheusbsilva137
approved these changes
Jan 18, 2025
matheusbsilva137
requested changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #34873