-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow searches by exact term to increase performance #34954
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34954 +/- ##
========================================
Coverage 59.12% 59.12%
========================================
Files 2819 2819
Lines 67856 67856
Branches 15115 15115
========================================
Hits 40123 40123
Misses 24905 24905
Partials 2828 2828
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some tests :whip:
Proposed changes (including videos or screenshots)
Allow searches by exact term in room name using quotes to have a better performance avoiding usage of regex.
This helps workspaces with large amounts of data that need to perform searches and have the full room name. Since MongoDB doesn't use indexes when using regex, this is an alternative.
Issue(s)
Steps to test or reproduce
http://localhost:3000/api/v1/livechat/rooms?count=25&roomName=%22Visitor%22&sort=%7B%22ts%22%3A-1%7D
Or
Guest
field use the quotes to search for a room name. (Ex: "Visitor")Further comments
SUP-707
Indexes PR