Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve permissions search #34939

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jan 13, 2025

CONN-458

Proposed changes (including videos or screenshots)

Searching permissions was only working with the words of the permission's ID.
Kapture 2025-01-09 at 15 35 35

Now the search results also matches with the translation on the UI.
Kapture 2025-01-13 at 11 26 39

Issue(s)

closes #34843
closes #28227
closes #22295
closes #27844
closes #30983

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 13, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 3961d42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (c75d771) to head (3961d42).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34939      +/-   ##
===========================================
- Coverage    59.12%   59.12%   -0.01%     
===========================================
  Files         2819     2819              
  Lines        67856    67852       -4     
  Branches     15115    15115              
===========================================
- Hits         40123    40119       -4     
  Misses       24905    24905              
  Partials      2828     2828              
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34939/

Built to branch gh-pages at 2025-01-17 21:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@juliajforesti juliajforesti force-pushed the feat/search-permissions branch 4 times, most recently from de4d4cf to f275d82 Compare January 15, 2025 18:16
@juliajforesti juliajforesti force-pushed the feat/search-permissions branch from e03b024 to c5c22ec Compare January 17, 2025 13:16
@juliajforesti juliajforesti marked this pull request as ready for review January 17, 2025 14:36
@juliajforesti juliajforesti requested a review from a team as a code owner January 17, 2025 14:36
@juliajforesti juliajforesti added this to the 7.3.0 milestone Jan 17, 2025
Copy link
Contributor

@rique223 rique223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Julia 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants