Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile errors when linked with Ventilator project #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compile errors when linked with Ventilator project #4

wants to merge 1 commit into from

Conversation

twslankard
Copy link
Member

No description provided.

@twslankard twslankard requested a review from martukas September 13, 2020 21:18
martukas
martukas approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@martukas martukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Except I would also merge this into the upstream_candidate branch, so we can submit this as a fix to the original authors. That's what that branch is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martukas martukas martukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twslankard @martukas