Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update GO and operator versions #18

Merged
merged 2 commits into from
Jan 28, 2024
Merged

update GO and operator versions #18

merged 2 commits into from
Jan 28, 2024

Conversation

almoggue
Copy link
Contributor

@almoggue almoggue commented Jan 24, 2024 •
edited
Loading

  • update GO version to 1.21.5
  • fix CVEs by updating GO packages
  • update tests:
    • operator version 7.2.4-12
    • update k8s version 1.26
  • enable running CI action manually

@almoggue almoggue force-pushed the almog-update-go-and-opeartor-versions-RED-113638 branch from f43fda8 to 5ffe127 Compare January 24, 2024 11:10
@almoggue almoggue force-pushed the almog-update-go-and-opeartor-versions-RED-113638 branch from 5ffe127 to f17b77f Compare January 24, 2024 11:20
@almoggue almoggue marked this pull request as ready for review January 24, 2024 12:43
@almoggue almoggue marked this pull request as draft January 24, 2024 12:59
@alon-zada alon-zada self-requested a review January 25, 2024 07:38
alon-zada
alon-zada reviewed Jan 25, 2024
View reviewed changes
Copy link

@alon-zada alon-zada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Please view non-blocking comments.
like the declarative pipelines reminded me how easy they are 👍 although the testing imo should be by running a python script and not bash cmds in the yaml but unrelated to the pr.

bootstrap/README.md
@@ -54,7 +54,7 @@ kind: RedisEnterpriseDatabase
metadata:
name: mydb
spec:
memory: 100MB
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preserveUnknownFields: false

docs/guides/using-the-plugin-on-k8s.md
@@ -72,7 +72,7 @@ kind: RedisEnterpriseDatabase
metadata:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be allied please consider adding the label to the REDB metadata here:
labels:
app: redis-enterprise

bootstrap/README.md
@@ -54,7 +54,7 @@ kind: RedisEnterpriseDatabase
metadata:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here:
to be allied please consider adding the label to the REDB metadata here:
labels:
app: redis-enterprise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@alon-zada alon-zada self-requested a review January 25, 2024 08:01
alon-zada
alon-zada approved these changes Jan 25, 2024
View reviewed changes
Copy link

@alon-zada alon-zada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comments :)

@almoggue almoggue requested a review from alon-zada January 25, 2024 11:33
alon-zada
alon-zada approved these changes Jan 25, 2024
View reviewed changes
Copy link

@alon-zada alon-zada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@almoggue almoggue marked this pull request as ready for review January 28, 2024 07:28
@almoggue almoggue merged commit 2508649 into main Jan 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alon-zada alon-zada alon-zada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almoggue @alon-zada