Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Dubbing #50

Merged
merged 16 commits into from
Sep 2, 2024
Merged

Feature Dubbing #50

merged 16 commits into from
Sep 2, 2024

Conversation

StephenHodgson
Copy link
Member

  • dubbing access; upload, asynchronous partial download, & transcriptions
  • dubbing unit test on the sample audio file. confirmed for videos too, you just might need to enable the watermark depending on your price tier

Changes from #48

@StephenHodgson StephenHodgson mentioned this pull request Jul 21, 2024
@StephenHodgson StephenHodgson changed the title Feature/dubbing Feature Dubbing Jul 21, 2024
@StephenHodgson StephenHodgson marked this pull request as draft July 21, 2024 17:59
@StephenHodgson
Copy link
Member Author

StephenHodgson commented Sep 2, 2024

CC @austinbhale I made some edits you'll prob want to account for.

I removed some properties that didn't seem to be part of the public api surface anymore.
I also changed the request class to accept multiple files and be immutable.

I'm also considering just removing the WaitForDubbingCompletionAsync and just have the StartDubbingAsync be one call instead of multiple.

@StephenHodgson StephenHodgson marked this pull request as ready for review September 2, 2024 03:41
@StephenHodgson StephenHodgson merged commit 56da036 into development Sep 2, 2024
1 check passed
@StephenHodgson StephenHodgson deleted the feature/dubbing branch September 2, 2024 03:42
@austinbhale
Copy link
Contributor

Awesome, thank you for all the updates! Currently hoping ElevenLabs improves their dubbing quality for some languages 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants