Fix for wru #140
Merged
Fix for wru #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1beb
reviewed
Sep 15, 2022
| @@ -42,7 +42,7 @@ map_interactive <- function(voter_file, | |||
| latitude = "lat", | |||
| longitude = "lon") { | |||
|
|
|||
| if (class(voter_file) == "data.frame" & any(colnames(voter_file) == "geometry")) { | |||
| if (is.data.frame(voter_file) & any(colnames(voter_file) == "geometry")) { | |||
1beb
reviewed
Sep 15, 2022
| # Use surname only | ||
| if (surname_only) { | ||
| new_voter_file <- data.frame(surname = surnames) | ||
| # Calculate probabilities using surnames only | ||
| probabilities <- suppressWarnings( | ||
| wru::merge_surnames( | ||
| merge_surnames_copy( | ||
| voter.file = new_voter_file, | ||
| surname.year = 2010, |
There was a problem hiding this comment.
May wish to make this a parameter given the new data for 2020 is widely available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR!
Please list any Issues this PR addresses
In 2-3 sentences or a brief list, describe changes implemented in this PR
wru(NAMESPACE error kosukeimai/wru#70)wru. If the user sets these toTRUE, they will be warned and the values will be forced toFALSEyearfield