Fix service parameter

ProfessionalWiki · Jul 4, 2018 · c654d4c · c654d4c
1 parent 7810137
commit c654d4c
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 1 deletion.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -7,6 +7,7 @@ different releases and which versions of PHP and MediaWiki they support, see the
 
 Released on July 4th, 2018.
 
+* Fixed regression introduced in 5.5.0 causing the `#display_map` parameter `service` to often be ignored
 * Fixed fatal error when using `#display_map` parameter `circles`
 * Fixed fatal error when using `#display_map` parameter `rectangles`
 * Fixed `#display_map` parameter `rectangles` fill color modifier (it is no longer ignored)

diff --git a/src/ParameterExtractor.php b/src/ParameterExtractor.php
@@ -19,7 +19,7 @@ class ParameterExtractor {
 	public function extract( array $parameterNames, array $rawParameters ) {
 		foreach( $parameterNames as $parameterName ) {
 			foreach ( $rawParameters as $rawName => $rawValue ) {
-				if ( strtolower( $rawName ) === $parameterName ) {
+				if ( trim( strtolower( $rawName ) ) === $parameterName ) {
 					return trim( $rawValue );
 				}
 			}

diff --git a/tests/Integration/Parser/DisplayMapTest.php b/tests/Integration/Parser/DisplayMapTest.php
@@ -135,4 +135,13 @@ public function testRectangleFillColorIsUsed() {
 		);
 	}
 
+	public function testServiceSelectionWorksWhenItIsPrecededByMultipleParameters() {
+		$this->assertContains(
+			'maps-googlemaps3',
+			$this->parse(
+				"{{#display_map:rectangles=\n  1,1:2,2~title~text~color\n| scrollwheelzoom=off\n| service = google}}"
+			)
+		);
+	}
+
 }
diff --git a/tests/Unit/ParameterExtractorTest.php b/tests/Unit/ParameterExtractorTest.php
@@ -65,4 +65,14 @@ public function testWhenUpperCaseIsUsedInTheName_itIsStillFound() {
 		);
 	}
 
+	public function testNameHasSpacesAroundIt_itIsStillFound() {
+		$this->assertSame(
+			'value',
+			( new ParameterExtractor() )->extract(
+				[ 'name' ],
+				[ '  name   ' => 'value' ]
+			)
+		);
+	}
+
 }