Pick up trace context from run labels #16346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bunchesofdonald
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
CodSpeed Performance ReportMerging #16346 will not alter performanceComparing Summary
|
|
LGTM!! |
bunchesofdonald
changed the title
Base automatically changed from
jean/cloud-740-update-flow-run-instrumentation-to-use-runtelemetry-class
to
main
December 12, 2024 16:52
bunchesofdonald
force-pushed
the
CLOUD-732
branch
from
cd857aa to
672d8f3
Compare
EmilRex
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: nate nowack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the RunTelemetry class to pull the traceparent from the runs labels. A traceparent can be added to these labels by server-side code. For instance if a run is Late when we transition to Late the server will start a span and store the traceparent in the flow run's labels. This way when the flow run is later picked up by a worker this "Late" span becomes the root span for the trace.
Related to CLOUD-732