Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki Revision "23R2", codename "Towers". #106

Closed
wants to merge 3 commits into from
+10 −9
Closed

Wiki Revision "23R2", codename "Towers". #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8bceae
Placeholder commit
jtghph Nov 1, 2023
bf4ebd4
Revert "Force LF line break (#85)"
jtghph Nov 2, 2023
7d3ef50
wdym?
jtghph Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@
Dockerfile text

## DOCUMENTATION
*.markdown text eol=lf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces git to convert line-endings to Unix LF (\n) instead of Windows CRLF (\r\n). This shouldn't be removed as this may cause problems during compilation when we unknowingly merge a commit with CRLF endings and something screws up in the compile process because of it because we run that on ubuntu-latest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the rest of your .md commits to CRLF from what I can assume seeing as literally nothing changed but github says it does. This looks awful on the git blame.

*.md text eol=lf
*.mdwn text eol=lf
*.mdown text eol=lf
*.mkd text eol=lf
*.mkdn text eol=lf
*.mdtxt text eol=lf
*.mdtext text eol=lf
*.txt text eol=lf
*.markdown text
*.md text
*.mdwn text
*.mdown text
*.mkd text
*.mkdn text
*.mdtxt text
*.mdtext text
*.txt text
AUTHORS text
CHANGELOG text
CHANGES text
Expand Down
1 change: 1 addition & 0 deletions BUILD-FROM-SOURCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# PLACEHOLDER COMMIT, will be removed, changed, or reverted as PR progresses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you even make a placeholder commit

# Building from source

* Even though it is well-explained, building from source requires skill, internet and time.
Expand Down
Loading