Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to all issues in the 3.7.2 section of the changelog #279

Merged

Conversation

rodrigoprimo
Copy link
Contributor

Description

This PR adds links to all issues in the 3.7.2 section of the changelog. I also checked for grammar or Markdown errors, but I did not find anything.

Related issues/external references

Part of #244

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@jrfnl jrfnl modified the milestones: 3.9.0, 3.8.x Next Jan 16, 2024
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigoprimo ! Great start for that issue.

@jrfnl jrfnl merged commit 17a4c19 into PHPCSStandards:master Jan 16, 2024
40 checks passed
@rodrigoprimo rodrigoprimo deleted the changelog-improvements-3-7-2 branch January 16, 2024 19:09
@rodrigoprimo
Copy link
Contributor Author

Thanks for the quick review, @jrfnl! For future PRs for that issue, do you prefer that I create one PR for each release, or is it fine to group a few releases in a single PR? I think that, especially for smaller releases, grouping them should allow us to move faster and will not make the review process significantly harder. That being said, I'm happy to proceed as you prefer.

@jrfnl
Copy link
Member

jrfnl commented Jan 16, 2024

Thanks for the quick review, @jrfnl! For future PRs for that issue, do you prefer that I create one PR for each release, or is it fine to group a few releases in a single PR?

@rodrigoprimo Thanks for asking. I'm fine with grouping the updates for multiple releases in a single PR, as long as a note is left on the #244 ticket to "claim" the releases which are being worked on, to prevent duplication of efforts by multiple people.

Also, I know from my own experience creating #243, that it can get tedious working on these kind of updates for too long at a time, so it's fine to do a few releases, commit & PR and continue another time with other releases.
(though #243 probably involved a lot more research than will be needed for the remaining work)

@rodrigoprimo
Copy link
Contributor Author

Sounds good to me. I will try to do a few per week, and I will make sure to leave a comment in the issue claiming the releases before starting.

@jrfnl
Copy link
Member

jrfnl commented Jan 16, 2024

Just noticed while reviewing your next PR that the links all use issues and are not always the canonical link. While I realize that currently works in GitHub, that hasn't always been the case, so I prefer to err on the side of caution and to always use the canonical link.

@jrfnl jrfnl modified the milestones: 3.8.x Next, 3.9.0 Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants