Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] PSR12 - Closing Brace #170

Merged

Conversation

dingo-d
Copy link
Contributor

@dingo-d dingo-d commented Dec 16, 2023

The PR contains the documentation for the PSR12/Classes/ClosingBrace sniff.

Description

This PR will add the documentation for the above-mentioned sniff, according to the official standard definitions.

Suggested changelog entry

Add documentation for the PSR12 ClosingBrace sniff

Related issues/external references

Part of #148

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dingo-d Thank you for taking this sniff on. Code samples, doc formatting etc, all looking good. I just have a few remarks/questions about the standard description itself. See the inline notes.

src/Standards/PSR12/Docs/Classes/ClosingBraceStandard.xml Outdated Show resolved Hide resolved
src/Standards/PSR12/Docs/Classes/ClosingBraceStandard.xml Outdated Show resolved Hide resolved
src/Standards/PSR12/Docs/Classes/ClosingBraceStandard.xml Outdated Show resolved Hide resolved
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those updates @dingo-d ! LGTM.

Don't worry about rebasing, I'll just squash-merge it if that's okay with you.

@jrfnl jrfnl merged commit d783b20 into PHPCSStandards:master Jan 3, 2024
38 checks passed
jrfnl pushed a commit that referenced this pull request Jan 3, 2024
* Add the documentation for the PSR12 Closing Brace Sniff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants