-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] PSR12 - Closing Brace #170
[Documentation] PSR12 - Closing Brace #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dingo-d Thank you for taking this sniff on. Code samples, doc formatting etc, all looking good. I just have a few remarks/questions about the standard description itself. See the inline notes.
Co-authored-by: Juliette <[email protected]>
Co-authored-by: Juliette <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those updates @dingo-d ! LGTM.
Don't worry about rebasing, I'll just squash-merge it if that's okay with you.
* Add the documentation for the PSR12 Closing Brace Sniff
The PR contains the documentation for the PSR12/Classes/ClosingBrace sniff.
Description
This PR will add the documentation for the above-mentioned sniff, according to the official standard definitions.
Suggested changelog entry
Add documentation for the PSR12 ClosingBrace sniff
Related issues/external references
Part of #148
Types of changes
PR checklist