Fixing multiplying by a constant #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiplying by a constant normally adds an extra parameter from the ConstantKernel, which breaks the code; we need to call ConstantKernel directly and specify that this should be an immutable parameter. Also removed the frivolous differences between rmjarvis/treegp (which this was originally cloned from) and pfleget/treegp (which this is being pushed to.
peterkentkiernan
force-pushed
the
Bug-fix-treegp
branch
from
f37f012 to
629133c
Compare
|
@peterkentkiernan I am sorry to come back so late on that PR. I tried to reproduce the error but I am not able to reproduce it... I am using the version Do you have an example of the problem? |
PFLeget
requested changes
Dec 6, 2023
| return None | ||
| else: | ||
| L = get_correlation_length_matrix(corr_length, g1, g2) | ||
| invLam = np.linalg.inv(L) | ||
| kernel_used = sigma**2 * self.kernel_class(invLam=invLam) |
There was a problem hiding this comment.
Having an example of this failing can be nice. I am not able to reproduce this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiplying by a constant without specifying adds an extra parameter, which breaks the code. Instead, we need to specify that the parameter in the constant kernel should not be changed. (I also fixed some minor oversights on checking if e or g was out of bounds.)