Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): flex a3 needs mating surface #17281

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(shared-data): flex a3 needs mating surface #17281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17520b9
fix(shared-data): flex a3 needs mating surface
sfoster1 Jan 15, 2025
d1c1c41
fixup: heal lint
sfoster1 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions api/src/opentrons/protocol_engine/state/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Protocol engine commands sub-state."""

from __future__ import annotations

import enum
Expand Down Expand Up @@ -304,7 +305,7 @@ def _handle_queue_command_action(self, action: QueueCommandAction) -> None:
# TODO(mc, 2021-06-22): mypy has trouble with this automatic
# request > command mapping, figure out how to type precisely
# (or wait for a future mypy version that can figure it out).
queued_command = action.request._CommandCls.model_construct( # type: ignore[call-arg]
queued_command = action.request._CommandCls.model_construct(
id=action.command_id,
key=(
action.request.key
Expand Down Expand Up @@ -506,7 +507,10 @@ def _handle_door_change_action(self, action: DoorChangeAction) -> None:
pass
case QueueStatus.RUNNING | QueueStatus.PAUSED:
self._state.queue_status = QueueStatus.PAUSED
case QueueStatus.AWAITING_RECOVERY | QueueStatus.AWAITING_RECOVERY_PAUSED:
case (
QueueStatus.AWAITING_RECOVERY
| QueueStatus.AWAITING_RECOVERY_PAUSED
):
self._state.queue_status = QueueStatus.AWAITING_RECOVERY_PAUSED
elif action.door_state == DoorState.CLOSED:
self._state.is_door_blocking = False
Expand Down
1 change: 1 addition & 0 deletions shared-data/deck/definitions/5/ot3_standard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@
"id": "A3",
"areaType": "slot",
"offsetFromCutoutFixture": [0.0, 0.0, 0.0],
"matingSurfaceUnitVector": [-1, 1, -1],
"boundingBox": {
"xDimension": 128.0,
"yDimension": 86.0,
Expand Down
Loading