refactor(components, protocol-designer): menuList and MenuItem cleanup for helix #17257
Conversation
jerader
requested review from
mjhuff,
koji and
ncdiehl11
and removed request for
a team
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepOverflowMenu.tsx
Show resolved
Hide resolved
components/src/constants.ts
Outdated
| @@ -0,0 +1,80 @@ | |||
| // constant used for filtering out controls in Storybook that include StyleProps | |||
| export const allDefaultStorybookControlsWithStyleProps: string[] = [ | |||
There was a problem hiding this comment.
sorry, can you elaborate on why we need this? Also, can we pull from somewhere like style-props.ts?
There was a problem hiding this comment.
As Nick said, you can pull all items without defining a new const.
the easiest way would be exporting STYLE_PROPS in style-props.ts and feed it to a stories.
There was a problem hiding this comment.
Mel has a storybook requirement where if you extend your component's props to include StyleProps, each of those props show up in storybook as something you can control. This constant removes that list. However, i am not sure if this is the best approach to remove that list.
There was a problem hiding this comment.
oops didnt' see Koji's response initially when i wrote my comment -- sounds good, I'll clean it up and export STYLE_PROPS
closes AUTH-1153 AUTH-1152
Overview
MenuListandMenuItemclean up & refinement as part of helix workTest Plan and Hands on Testing
check adding liquids overflow menu in PD, step overflow menu in protocol steps in PD, check overflow menus in the app - i did some smoke testing and i think they work as expected, but please do some additional smoke testing to be safe
Changelog
clean up the storybooks for both
create const to be used for storybook
use MenuList in a few places in PD
Risk assessment
low