try explaining driver behaviors #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multun
reviewed
Jun 5, 2024
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Outdated
Show resolved
Hide resolved
emersion
reviewed
Jun 5, 2024
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Show resolved
Hide resolved
eckter
reviewed
Jun 5, 2024
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Outdated
Show resolved
Hide resolved
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Show resolved
Hide resolved
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Show resolved
Hide resolved
emersion
reviewed
Jun 5, 2024
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Show resolved
Hide resolved
emersion
reviewed
Jun 5, 2024
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Outdated
Show resolved
Hide resolved
emersion
reviewed
Jun 5, 2024
content/docs/reference/design-docs/train-sim-v3/driver-behavior-modules.en.md
Outdated
Show resolved
Hide resolved
emersion
reviewed
Jun 5, 2024
| - driver behavior modules are queried for each driving instruction, and the decision with the lowest | ||
| acceleration is choosen | ||
| - this decision is submitted for truncation to all driver behavior modules. The final decision is the one | ||
| with the smallest `dt` |
There was a problem hiding this comment.
"The final decision is the one with the smallest dt"
AFAIU this isn't what we documented in the new "loop" section, I suppose this old section was outdated or confusing? (Just checking we're not missing something here)
There was a problem hiding this comment.
I think its a paragraph that was written before the last design decisions. Do you have any idea about this @multun or @woshilapin ?
emersion
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #205