chore: update dependencies on openjd packages #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
force-pushed
the
ddneilson/update_ojd_deps
branch
2 times, most recently
from
afecdd7 to
c42f7fd
Compare
ddneilson
changed the title
ddneilson
force-pushed
the
ddneilson/update_ojd_deps
branch
2 times, most recently
from
fbcb12e to
cbd8989
Compare
Summary: Newer versions of the openjd-model and openjd-sessions packages have been released. The changes include some quality-of-life improvements to template input validation, so we want to update the cli to have these changes. This updates the cli dependencies and makes the required changes. Signed-off-by: Daniel Neilson <[email protected]>
ddneilson
force-pushed
the
ddneilson/update_ojd_deps
branch
from
cbd8989 to
a86f88d
Compare
AWS-Samuel
approved these changes
Feb 12, 2024
epmog
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Newer versions of the openjd-model and openjd-sessions packages have been released. The changes include some quality-of-life improvements to template input validation, so we want to update the cli to have these changes.
What was the solution? (How)
Update the dependencies, and apply the changes dictated by the breaking changes in both.
SchemaVersionenum was removed fromopenjd-modelin favour ofTemplateSpecificationVersionParametertype was removed fromopenjd-sessionsin favour of the parameter types defined inopenjd-modelWhat is the impact of this change?
Better validation errors for customers.
How was this change tested?
I ran the unit tests, and I've been running the cli with a couple of job templates.
Was this change documented?
N/A
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.