Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Update links to point to latest #38

Merged
3 commits merged into from
Nov 15, 2022
Merged

schema: Update links to point to latest #38

3 commits merged into from
Nov 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2022

#34

@ghost ghost requested review from lgs85 and duncandewhurst November 10, 2022 11:46
@ghost ghost force-pushed the 2022-12-10-doc-links branch from ec2d7f3 to 9b6bf8d Compare November 10, 2022 11:46
@ghost ghost assigned lgs85 and duncandewhurst Nov 10, 2022
@ghost
Copy link
Author

ghost commented Nov 10, 2022

@lgs85 @duncandewhurst Unfortunately, you'll need to check every link by hand and fix some. I tried at random the one in the download data box and it's now broken. Old: https://open-fibre-data-standard.readthedocs.io/en/latest/reference/publication_formats.html New: https://open-fibre-data-standard.readthedocs.io/en/latest/reference/publication_formats/index.html Is this expected?

If so you could list changes needed on this PR, or even do a commit yourself and add to this PR before sending to a dev.

@lgs85
Copy link

lgs85 commented Nov 10, 2022

I tried at random the one in the download data box and it's now broken. Old: https://open-fibre-data-standard.readthedocs.io/en/latest/reference/publication_formats.html New: https://open-fibre-data-standard.readthedocs.io/en/latest/reference/publication_formats/index.html Is this expected?

Yes, this reflects a change to the docs. @duncandewhurst we should add some documentation somewhere to make sure we pick up on these.

@duncandewhurst
Copy link
Contributor

I used grep /latest/ * in cove_ofds/templates/cove_ofds to find and check all the URLs. I've fixed the broken URLs in 13309ca.

I think I've resolved the merge conflict correctly, but please check!

@duncandewhurst we should add some documentation somewhere to make sure we pick up on these.

Already noted in Open-Telecoms-Data/standard-development-handbook#21, great minds etc. etc.

Copy link
Contributor

@Lathrisk Lathrisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didn't test all the links but I did grab a few at random and they all seem to link correctly.

Copy link
Collaborator

@codemacabre codemacabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked several links and they LGTM

@ghost ghost merged commit 184ff6d into live Nov 15, 2022
@ghost ghost deleted the 2022-12-10-doc-links branch November 15, 2022 08:31
@ghost
Copy link
Author

ghost commented Nov 15, 2022

This was a small change so I merged it. Have verified it's on live fine.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants