Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_warning_in_flow_save #10338

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add_warning_in_flow_save #10338

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
795d85f
add_warning_in_flow_save
clackhan Sep 27, 2023
682d765
refine
clackhan Oct 7, 2023
977c11f
Merge branch 'master' into add_warning_in_flow_save
ShawnXuan Oct 7, 2023
3ff8b5d
Merge branch 'master' into add_warning_in_flow_save
clackhan Nov 6, 2023
3fa4beb
Merge branch 'master' into add_warning_in_flow_save
levi131 Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/oneflow/framework/check_point_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,12 @@ def save(
"""
if isinstance(path_or_buffer, str):
path_or_buffer = Path(path_or_buffer)
if os.path.isdir(path_or_buffer) and not save_as_external_data:
path_or_buffer = path_or_buffer / "model.pt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model.of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model.of

已修改

warnings.warn(
f"The save path cannot be a dir name from oneflow-0.9.1! The system
will automatically complete it into the file name as {path_or_buffer}"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        warnings.warn(
            f"The save path cannot be a dir name from oneflow-0.9.1! The system "
            f"will automatically complete it into the file name as {path_or_buffer}"
        )


if isinstance(obj, graph_util.Graph):
if not _is_path(path_or_buffer):
Expand Down