Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add user action component #4088

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add user action component #4088

wants to merge 2 commits into from

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented Jan 17, 2025 •
edited
Loading

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes)

What is the new behavior?

A little util component to wrap around actions logged in user can do. Useful prep for #4044.
Reduces components that access the user store.

One small user change:
Screenshot 2025-01-17 at 14 35 31

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

Git Issues

Closes #4079

@benfurber benfurber requested a review from a team as a code owner January 17, 2025 15:15
@benfurber benfurber force-pushed the feat/user-action-component branch from 4a35308 to 0e08cb9 Compare January 17, 2025 15:22
@benfurber
Copy link
Member Author

@davehakkens / @dalibormrska - Thoughts on updating the label for the sign-up buttons on the doc list pages?

@cypress Cypress
Copy link

cypress bot commented Jan 17, 2025 •
edited
Loading

onearmy-community-platform    Run #6785

Run Properties:  status check failed Failed #6785  •  git commit 2c0e91d5a9: feat: add UserAction across app
Project onearmy-community-platform
Branch Review pull/4088
Run status status check failed Failed #6785
Run duration 06m 12s
Commit git commit 2c0e91d5a9: feat: add UserAction across app
Committer Ben Furber
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 79
View all changes introduced in this branch ↗︎

Tests for review

Failed  src/integration/research/write.spec.ts • 1 failed test • ci-chrome

View Output Video

Test Artifacts
[Research] > [Create research article] > [By Authenticated] Test Replay Screenshots Video
Failed  src/integration/library/write.spec.ts • 1 failed test • ci-chrome

View Output Video

Test Artifacts
[Library] > [Create a project] > [By Authenticated] Test Replay Screenshots Video
Flakiness  notifications.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Notifications] > [are generated by clicking on useful for projects] Test Replay Screenshots Video
Flakiness  research/follow.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Research] > [By Authenticated] > [Follow button] Test Replay Screenshots Video
Flakiness  questions/read.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Questions] > [Individual questions] > [By Everyone] Test Replay Screenshots Video

@benfurber benfurber force-pushed the feat/user-action-component branch 2 times, most recently from 6ddc18f to 92e9c12 Compare January 17, 2025 16:01
@benfurber benfurber force-pushed the feat/user-action-component branch from 92e9c12 to 39aea26 Compare January 17, 2025 16:12
@benfurber benfurber force-pushed the feat/user-action-component branch from 39aea26 to 2c0e91d Compare January 17, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Mod: Library 📰 Mod: Research 🔬
Projects
Core Team - BAU list
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] add user action util component
1 participant
@benfurber