[IMP] rename_models: add condition to check version and existence of ir_property table #395
Conversation
…ir_property table
| (old,), | ||
| ) | ||
| field_ids = [x[0] for x in cr.fetchall()] | ||
| logged_query( |
There was a problem hiding this comment.
This should go outside the if.
| ), | ||
| ) | ||
| if field_ids: | ||
| if version_info[0] < 18 and table_exists(cr, "ir_property"): |
There was a problem hiding this comment.
What would be the reason to check if ir_property exists as a table?
There was a problem hiding this comment.
I'm just denying the case if the ir_property table exists and the version is >= 18.0. because in fact if you use a database from 17.0 or earlier to migrate data to version >= 18.0, the ir_property table still exists and is just no longer used.
There was a problem hiding this comment.
Agreed that even in version 18 no operations should be performed in the table even if it exists! I would say checking the version is enough because we can rely on the table existing in earlier versions.
There was a problem hiding this comment.
thanks, maybe it's redundant. i will update it in next patch
model
ir.propertywas removed in commit odoo/odoo@de302c2 in version18.0so if new databases is initialized from 18.0 onwards will not haveir_propertytable then there will be an error exception thatrelation ir_property does not existwhen using therename_modelsfunction