Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] copy_columns: Only copy not null values #392

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[IMP] copy_columns: Only copy not null values #392

merged 1 commit into from
Dec 4, 2024

Conversation

etobella
Copy link
Member

@etobella etobella commented Dec 4, 2024

StefanRijnhart
StefanRijnhart reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Is this just a performance improvement or does it solve errors?
I think I would prefer the commit to include a little more detail. Maybe [IMP] copy_columns: Only copy not null values?

@etobella
Copy link
Member Author

etobella commented Dec 4, 2024

It should increase the speed. The code itself is right.

StefanRijnhart
StefanRijnhart approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart StefanRijnhart changed the title [IMP] Only copy not null values [IMP] copy_columns: Only copy not null values Dec 4, 2024
MiquelRForgeFlow
MiquelRForgeFlow approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza pedrobaeza merged commit 29d201f into OCA:master Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@etobella @StefanRijnhart @pedrobaeza @MiquelRForgeFlow @OCA-git-bot