Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][REF] l10n_be_cooperator_national_number: Move method, rename (other) method #136

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

carmenbianca
Copy link
Member

Two-in-one because I cbf with a bajillion PRs.

Split from #131.

@carmenbianca carmenbianca force-pushed the 16.0-ref-validate branch 2 times, most recently from 0026299 to f94a4f6 Compare June 13, 2024 08:14
Also implemented a slight fix such that `sudo()` is not necessary to
call this method.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small (but important) change request. all the rest lgtm, thanks!

Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! 🎉

@huguesdk
Copy link
Member

this should be a major version upgrade.

@carmenbianca
Copy link
Member Author

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-136-by-carmenbianca-bump-major, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 14, 2024
Signed-off-by carmenbianca
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-136-by-carmenbianca-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6b2fe97 into OCA:16.0 Jun 14, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b949f36. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants