-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][REF] l10n_be_cooperator_national_number: Move method, rename (other) method #136
Conversation
0026299
to
f94a4f6
Compare
8ae6d5a
to
9d6ff0e
Compare
Also implemented a slight fix such that `sudo()` is not necessary to call this method. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
9d6ff0e
to
43f0b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small (but important) change request. all the rest lgtm, thanks!
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
43f0b2a
to
15f2d84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay! 🎉
this should be a major version upgrade. |
/ocabot merge major |
Hey, thanks for contributing! Proceeding to merge this for you. |
It looks like something changed on |
Congratulations, your PR was merged at b949f36. Thanks a lot for contributing to OCA. ❤️ |
Two-in-one because I cbf with a bajillion PRs.
Split from #131.