[FIX] l10n_be_cooperator_national_number: Allow removal of national n…

…umber

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

l10n_be_cooperator_national_number/models/res_partner.py

@@ -35,18 +35,22 @@ def get_be_national_register_number(self):
     def update_belgian_national_number(self, national_number):
         self.ensure_one()
         result = None
-        if national_number:
-            existing = self.get_be_national_register_number_id_number()
-            # Update
-            if existing:
+        existing = self.get_be_national_register_number_id_number()
+        # Update
+        if existing:
+            if not national_number:
+                # TODO: should we check against require_national_number before
+                # unlinking?
+                existing.unlink()
+            else:
                 existing.name = national_number
                 result = existing
-            # Create new
-            else:
-                values = {
-                    "name": national_number,
-                    "category_id": self.get_be_national_register_number_id_category().id,
-                    "partner_id": self.id,
-                }
-                result = self.env["res.partner.id_number"].create(values)
+        # Create new
+        elif national_number:
+            values = {
+                "name": national_number,
+                "category_id": self.get_be_national_register_number_id_category().id,
+                "partner_id": self.id,
+            }
+            result = self.env["res.partner.id_number"].create(values)
         return result

l10n_be_cooperator_national_number/readme/newsfragments/139.bugfix.rst

@@ -0,0 +1 @@
+Allow removal of national number.