[17.0][IMP] contract: Terminate contract lines with last_date_invoiced if it is higher than terminate date from wizard #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdauden
approved these changes
Jan 10, 2025
carlos-lopez-tecnativa
suggested changes
Jan 10, 2025
| self.contract_line_ids.filtered("is_stop_allowed").stop(terminate_date) | ||
| for line in self.contract_line_ids.filtered("is_stop_allowed"): | ||
| line.stop( | ||
| max(terminate_date, line.last_date_invoiced) |
There was a problem hiding this comment.
If any line does not have a date, I encounter this error
|
@sergio-teruel Tests should be welcome |
sergio-teruel
force-pushed
the
17.0-IMP-contract-terminate-last_invoice-date
branch
2 times, most recently
from
f1631c7 to
9b6b369
Compare
|
@carlos-lopez-tecnativa Fixed , thanks... @rousseldenis Oks.. |
…t is higher than terminate date from wizard
sergio-teruel
force-pushed
the
17.0-IMP-contract-terminate-last_invoice-date
branch
from
9b6b369 to
35852ea
Compare
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 607f6c1. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT52602
Well, when you have a contract with some lines with diferents recurrences you can different last date invoiced values so if you try to terminate all contrat from wizard you can obtain an error because the date in the wizard is lower than the last date invoiced in the line.
With this improvement user can choose if terminate the line with last date invoiced instead if is higher than the date of the wizard.
ping @carlosdauden @carlos-lopez-tecnativa