[18.0][MIG] contract #1136
Draft
[18.0][MIG] contract #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have contract lines with automatic price and your pricelist contains different prices per quantity, the price is not changed when computing quantity. This PR fixes this.
Bug description --------------- `account.analytic.contract.line` inherits `account.analytic.invoice.line` `account.analytic.invoice.line` defines field `analytic_account_id`: - comodel='account.analytic.account' `account.analytic.contract.line` redefines field `analytic_account_id`: - comodel='account.analytic.contract' On attempt to extend `account.analytic.invoice.line` model adding field that depends on `analytic_account_id.date_start` Odoo fails to update, because it adds this field to `account.analytic.contract.line` through inheritance, and `account.analytic.contract` model have no this field. What is done ------------ Change inheritance order: - `account.analytic.invoice.line` inherits `account.analytic.contract.line` - no file renames at this stage (this wil be done in next commit)
Runbot URL in old README.rst pointed to 10.0 runbot, fixed by upgrading template
Currently translated at 96.0% (96 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/nl/
Currently translated at 53.0% (53 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/de/
[UPD] Update contract.pot
Currently translated at 75.0% (75 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/de/ [UPD] README.rst
Currently translated at 98.0% (98 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/es/
Currently translated at 10.0% (10 of 100 strings) Translation: contract-11.0/contract-11.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract/pt_PT/
The test as it was, leaves to the demo pricelist the control on the price of the product, so other modules that modifies this pricelist will make the test to fail. This is the minimum change needed for avoiding the problem.
- Module: contract
- Summary: several terms where not translated to Spanish.
Currently translated at 99.0% (99 of 100 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/de/
Currently translated at 100.0% (109 of 109 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/es/
Currently translated at 100.0% (109 of 109 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/gl/
Currently translated at 100.0% (109 of 109 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/de/
Currently translated at 83.5% (91 of 109 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/it/
Currently translated at 100.0% (109 of 109 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/fr/
Currently translated at 100.0% (109 of 109 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/pt/
Currently translated at 51.8% (57 of 110 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/pt_BR/
Currently translated at 100.0% (110 of 110 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/de/
Currently translated at 40.9% (45 of 110 strings) Translation: contract-12.0/contract-12.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract/zh_CN/
Currently translated at 100.0% (313 of 313 strings) Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/it/
Fix ValueError: Deprecated usage of 'default_res_id', should use 'default_res_ids'.
Currently translated at 100.0% (313 of 313 strings) Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/es/
Currently translated at 100.0% (313 of 313 strings) Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/
Currently translated at 100.0% (314 of 314 strings) Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/it/
Currently translated at 100.0% (314 of 314 strings) Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/
Currently translated at 100.0% (315 of 315 strings) Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/it/
Currently translated at 66.0% (208 of 315 strings) Translation: contract-17.0/contract-17.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract/fi/
sbejaoui
force-pushed
the
18.0-mig-contract-sbj
branch
from
6d43cf7 to
b485a4f
Compare
|
I think we should wait till #1134 |
Totally agree. I opened this PR because I needed the contract stack for a poc |
sbejaoui
force-pushed
the
18.0-mig-contract-sbj
branch
from
b485a4f to
6a4d57f
Compare
sbejaoui
force-pushed
the
18.0-mig-contract-sbj
branch
from
6a4d57f to
87fb580
Compare
|
Please, cherry-pick #1156 to commit history. |
|
Please, cherry-pick #1169 to commit history. |
|
Please, cherry-pick #1175 to commit history. |
|
Hello @pedrobaeza @sbejaoui any updates here? From what I see, this #1134 doesn’t seem like it’ll be finished anytime soon. Could the migration be completed without it? |
|
This PR is draft also. My intention is to check the refactoring this month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.