Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] Bugfix in TreeView of account.payment.line (invisible vs column_invisible) #1385

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

DentalSoftworksDev
Copy link

Replaced "invisible" by "column_invisible" in tree view for 17.0 compatibility (new attribute 'column_invisible')

@pedrobaeza
Copy link
Member

The change is correct, but please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@pedrobaeza pedrobaeza added this to the 17.0 milestone Dec 12, 2024
@DentalSoftworksDev
Copy link
Author

The change is correct, but please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

Sorry for that - it's my first time to contribute and didn't found the document. Thanks for your help!

@DentalSoftworksDev DentalSoftworksDev changed the title Bugfix in TreeView of account.payment.line (invisible vs column_invisible) [17.0][FIX] Bugfix in TreeView of account.payment.line (invisible vs column_invisible) Dec 12, 2024
@DentalSoftworksDev
Copy link
Author

One change had to be reverted:

The button supports 'invisible' and this was correct for this place and usage.

@pedrobaeza
Copy link
Member

You need to squash all commits into one with the proper format.

@pedrobaeza
Copy link
Member

I'm afraid you are mangling more the commit history. You need to do an interactive rebasing over the main branch and rename the commit. It's similar to this: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@DentalSoftworksDev
Copy link
Author

Again: Many thanks for your advice.

Needed thousands of commits until I figured the correct procedure... failed when pushing without "--force".

Really appreciate your help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants