Fix issues with release.yaml due to breaking changes in actions/upload-artifact and actions/download-artifact #173
Conversation
actions/upload-artifact and actions/download-artifact both were updated with breaking changes which caused release.yaml not to run anymore. This attempts to fix the release mechanism to working order again. Key change is that upload-artifact must now use unique names and dowload-artifact must be changed to merge all files into a single directory for twine to pick up.
Apple silicon builds have a requirement for a recent pip.
|
@calbaker @kylecarow I've gotten the Would you both be OK with me setting up separate Apple Silicon and Apple Intel builds? Or do you have any thoughts on how to get a universal build working on cibuildwheel for Apple? See here if you'd like to look at the latest build errors: https://github.com/NREL/fastsim/actions/runs/12246134820/job/34161446298 |
Attempt to use separate intel and apple silicon builds vs trying to use the universal build for wheels. This is faciliated by using macos-13 (Intel) and macos-14 (Apple Silicon).
The variable 'MACOSX_DEPLOYMENT_TARGET=10.12' is needed to updated minimum supported macOS for this wheel.
|
Note: release is running clean (this version has the pypi deploy disabled): |
|
@michael-okeefe, could you investigate the failing checks in this PR? |
The `wheels.yml` file did not receive the required updates and changes needed for building with Mac OS for Apple Silicon AND Apple Intel. These changes have now been copied over such that the `wheels.yml` file is essentially the same as the first part of the `release.yml` file. We may be able to eliminate the `wheels.yml` workflow in the future although it is helpful as a check to confirm that the `release.yml` file (at least, the "build" section) will run without issue.
@calbaker It turned out that this branch was just out of date. We had removed the |
My understanding is that the tests pass and this can be merged, right @michael-okeefe ? |
@calbaker Yes, that is correct. Thank you. |
actions/upload-artifactandactions/download-artifactboth were updated with breaking changes which caused release.yaml not to run anymore. (NOTE: there were deprecations so keeping with the old version was not an option). This attempts to fix the release mechanism to working order again.Key change is that upload-artifact must now use unique names and dowload-artifact must be changed to merge all files into a single directory for twine to pick up.
v2.1.3+mod01)References: