-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hpxml file has a start to reading in the performance data points (line 850ish) #143
Open
kendallbaertlein
wants to merge
46
commits into
NREL:main
Choose a base branch
from
kendallbaertlein:ASHP-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note:; this covers the ENERGY STAR and HIgh efficiency cold climate heat pump upgrades from ResStock 2024. For details, see: https://resstock.nrel.gov/datasets https://www.nrel.gov/docs/fy24osti/89600.pdf Addresses NREL#128 - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
Various updates to accept HPXML files from OS-HPXML v1.7 (and therefore ResStock 3.2). Major changes and fixes: - Revised/renamed spa equipment - Fixed garage interior ceiling connections - Fixed issue with adjacent doors (e.g., for multi-family units, hallways) - PV model takes roof azimuth and tilt if not provided - Updated documentation A few things we haven't addressed yet (and probably won't until accepting OS-HPXML v1.8) - Cathedral ceilings - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
DSE is set to 1 for Room AC Fixes NREL#99 - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [ ] Update documentation as appropriate - [ ] Update changelog as appropriate
…is expecting files generated by ResStock or BEopt, and there were some issues with HPXML files not worth the time to resolve.
…. Thanks Kendall!
…tion etc. of detailed performance data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.