-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VASP main page updates #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reorganization and simplification is a great improvement.
My main comments are:
- Would it be best to remove the VASP sections that currently exist under Swift (https://nrel.github.io/HPC/Documentation/Systems/Swift/running/#running-vasp) and Vermilion (https://nrel.github.io/HPC/Documentation/Systems/Vermilion/running/#running-vasp-on-vermilion), and perhaps replace those with a link to this section, since you have provided examples for all systems here? At a minimum, that reduces duplication and would make it easier to maintain the example scripts moving forward.
- I had problems running the example scripts for Vermilion, per my comments. I know that's not the focus of this PR, so I wouldn't want to delay getting these changes incorporated just because of the issues with the vermilion examples. If there aren't quick fixes for the vermilion examples, we should probably create a GH Issue to keep track of getting them updated.
Thanks for the review @mcfarljm . I have a PR in (#501) to remove the VASP sections under Swift and Vermilion pages as you mentioned in your comment. |
Co-authored-by: John McFarland <[email protected]>
Co-authored-by: John McFarland <[email protected]>
Co-authored-by: John McFarland <[email protected]>
Co-authored-by: John McFarland <[email protected]>
Co-authored-by: John McFarland <[email protected]>
Co-authored-by: John McFarland <[email protected]>
Co-authored-by: John McFarland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noted a few spelling errors.
I think it's an improvement to have removed the multiple links/explanations of the benchmark studies repo, but do you think there should be one link to it on this page? I'm not sure if that info is helpful to some users.
Co-authored-by: Haley Yandt <[email protected]>
Co-authored-by: Haley Yandt <[email protected]>
Co-authored-by: Haley Yandt <[email protected]>
Co-authored-by: Haley Yandt <[email protected]>
Ported VASP friendly users documentation to main page and cut down text overall