-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge 4.2 development branch to master #21
Open
nikizadehgfdl
wants to merge
22
commits into
main
Choose a base branch
from
dev4.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esm4.2 development from Jessica Luo and Charles Stock
- For ESM4.2 production we needed a less restrict conservation threshold
Relax the conservation threshold
… chemoautotrophic bacterial processes in bacteria production and biomass accumulation.
Changes for ESM4.2 proto8 Changes answers
- This is required to work with updated MOM6 versions in 2022
Remove deprecated MOM6 interface
…duction calculation to close the alkalinity budget; increases in phosphorus burial to prevent P accumulation; improve chl in subtropical gyres; reductions in calcite and aragonite production
*New changes to COBALT for ESM4.2
Update dev4.2 with changes in FMS
There is a trailing i that breaks compile
merge dev4.2 to mergemaster for testing
updates from master for testing
…gnostics - Fixes from Charles Stock - 1) fix a bug in the benthic denitrification; and - 2) replace benthic calculations previously done with the bottom layer with an average over a specified thickness. - Merge some OBC changes from master branch to generic_tracer_utils.F90 These are interface changes needed to compile/run with the most recent MOM6/SIS2 commits
* Fix the benthic denitrification and bottom layer diagnotics
- Imbalance tolerance needs to be adjustable - It usually depends on the compute platform/compiler
Add imbalance tolerance to a namelist for dev4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@charliestock and @jessluo are we ready for this now that ESM4.2 is developed? These updates to COBALT seem like enhancements that everyone would benefit from.