Skip to content

Commit

Permalink
notimplementederrors raised on functions not-yet-used. uncomment the …
Browse files Browse the repository at this point in the history
…help function test in meta.yaml because we DO want those to work
  • Loading branch information
ilaflott committed Jan 6, 2025
1 parent bc4a39b commit 67b67ee
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 12 deletions.
3 changes: 2 additions & 1 deletion fre/check/frecheck.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from .frecheckexample import check_test_function

@click.group(help=click.style(" - access fre check subcommands", fg=(162,91,232)))
@click.group(help=click.style(" - access fre check subcommands (not implemented yet!)", fg=(162,91,232)))
def check_cli():
''' entry point to fre check click commands '''

Expand All @@ -13,6 +13,7 @@ def check_cli():
def function(uppercase):
""" - Execute fre check test """
check_test_function(uppercase)
raise NotImplementedError('fre check has not been implemented yet!')

if __name__ == "__main__":
check_cli()
3 changes: 2 additions & 1 deletion fre/list/frelist.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from .frelistexample import list_test_function

@click.group(help=click.style(" - access fre list subcommands", fg=(232,204,91)))
@click.group(help=click.style(" - access fre list subcommands (not implemented yet!)", fg=(232,204,91)))
def list_cli():
''' entry point to fre list click commands '''

Expand All @@ -13,6 +13,7 @@ def list_cli():
def function(uppercase):
""" - Execute fre list test """
list_test_function(uppercase)
raise NotImplementedError('fre list has not been implemented yet!')

if __name__ == "__main__":
list_cli()
2 changes: 1 addition & 1 deletion fre/pp/wrapper_script.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from fre.pp.trigger_script import trigger
from fre.pp.status_script import status_subtool

def run_all_fre_pp_steps(experiment = None, platform = None, target = None, config_file, branch = None, time = None):
def run_all_fre_pp_steps(experiment = None, platform = None, target = None, config_file = None, branch = None, time = None):
'''
Wrapper script for calling a FRE2 pp experiment with the canopy-style
infrastructure and fre-cli
Expand Down
3 changes: 2 additions & 1 deletion fre/run/frerun.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import click
from .frerunexample import run_test_function

@click.group(help=click.style(" - access fre run subcommands", fg=(164,29,132)))
@click.group(help=click.style(" - access fre run subcommands (not implemented yet!)", fg=(164,29,132)))
def run_cli():
''' entry point to fre run click commands '''

Expand All @@ -14,6 +14,7 @@ def run_cli():
def function(uppercase):
""" - Execute fre run test """
run_test_function(uppercase)
raise NotImplementedError('fre run has not been implemented yet!')

if __name__ == "__main__":
run_cli()
1 change: 1 addition & 0 deletions fre/test/fretest.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def test_cli():
def function(uppercase):
""" - Execute fre test test """
test_test_function(uppercase)
raise NotImplementedError('fre test has not been implemented yet!')

if __name__ == "__main__":
test_cli()
16 changes: 8 additions & 8 deletions meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ test:
- fre
- fre.app
- fre.catalog
# - fre.check
- fre.check
- fre.cmor
# - fre.list
- fre.list
- fre.make
- fre.pp
# - fre.run
# - fre.test
- fre.run
- fre.test
- fre.yamltools
commands:
- pylint --max-args 6 -ry --ignored-modules netCDF4,cmor fre/ || echo "pylint returned non-zero exit code and will kill the workflow. guarding against this now."
Expand All @@ -71,13 +71,13 @@ test:
- fre --help
- fre app --help
- fre catalog --help
# - fre check --help
- fre check --help
- fre cmor --help
# - fre list --help
- fre list --help
- fre make --help
- fre pp --help
# - fre run --help
# - fre test --help
- fre run --help
- fre test --help
- fre yamltools --help


Expand Down

0 comments on commit 67b67ee

Please sign in to comment.