Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MOM_generic_tracer.F90 to config_src/external/GFDL_ocean_BGC with no changes #790

Conversation

yichengt900
Copy link

@yichengt900 yichengt900 commented Dec 31, 2024

This PR relocates src/tracer/MOM_generic_tracer.F90 to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90 without introducing any code changes. This update should not affect baselines or the build process for the physics-only model.

To build the model with the generic tracer package, in addition to including the tracer folder, the following files from config_src/external/GFDL_ocean_BGC (or user custom versions) are required:

MOM_generic_tracer.F90
generic_tracer.F90
generic_tracer_utils.F90
FMS_coupler_util.F90

CC @theresa-morrison

* Move MOM_generic_tracer with no changes

Renames src/tracer/MOM_generic_tracer.F90
to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90

* Remove MOM_generic_tracer

Git rm MOM_generic_tracer.F90

---------

Co-authored-by: Theresa Morrison <[email protected]>
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this PR to move the MOM_generic_tracer.F90 file. This move has been extensively discussed both within the GFDL MOM6 dev team and at MOM6 consortium-wide development calls, and there is a broad consensus that this is the right thing to do.

@Hallberg-NOAA
Copy link
Member

Although this has been approved, it can not be rebased on the latest version of dev/gfdl, and hence can not be merged. Ordinarily we would be able to rebase a PR, but this requires that the box "Allow edits and access to secrets by maintainers" be checked when you created the PR.

@yichengt900
Copy link
Author

Thanks. @Hallberg-NOAA. Marshall pointed it out the same issue before, and it appears that the option Allow edits and access to secrets by maintainers does not show up when merging an organization fork (weird). I have manually merged the recent updates into my feature branch.

@Hallberg-NOAA
Copy link
Member

This has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/25891.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants