Document units of 62 real variables #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added standard-format unit descriptions for 62 real variables in comments scattered across 17 modules in the core, tracer, and both parameterizations directories. Another 6 comments were added noting dimensionally inconsistent expressions in the recently added subroutine vertFPmix. Only comments are changed and all answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #510 +/- ##
============================================
- Coverage 37.54% 37.54% -0.01%
============================================
Files 270 270
Lines 79030 79030
Branches 14633 14635 +2
============================================
- Hits 29671 29670 -1
- Misses 43892 43894 +2
+ Partials 5467 5466 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 28, 2023
|
This is PR being withdrawn and partially replaced by /pull/514 to avoid creating merge conflicts when the dimensionally incorrect expressions in MOM_vert_friction.F90 are corrected. These dimensional inconsistencies are highlighted in an issue at NCAR/issues/259. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added standard-format unit descriptions for 62 real variables in comments scattered across 17 modules in the core, tracer, and both parameterizations directories. Another 6 comments were added noting dimensionally inconsistent expressions in the recently added subroutine vertFPmix. Only comments are changed and all answers are bitwise identical.