Add proposal for @sheet to enable multiple stylesheets per file #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandclark
reviewed
Jan 9, 2025
dandclark
reviewed
Jan 9, 2025
AtSheet/explainer.md
Outdated
| [SameObject] readonly attribute StyleSheetList nestedStyleSheets; | ||
| }; | ||
| ``` | ||
| *Open issue: The name `nestedStyleSheets` is up for discussion* |
alisonmaher
reviewed
Jan 10, 2025
alisonmaher
reviewed
Jan 10, 2025
Co-authored-by: Dan Clark <[email protected]>
kbabbitt
reviewed
Jan 10, 2025
alisonmaher
approved these changes
Jan 14, 2025
|
|
||
| ```html | ||
| <style> | ||
| /* The following two imports should only make a single network request. */ |
There was a problem hiding this comment.
nit: these are missing indentation
| readonly attribute DOMString? name; | ||
| }; | ||
| ``` | ||
| *Open issue: |
| 1. Whether rules are applied automatically for `@sheet` definitions, or whether they need to be imported to apply. The CSS Working Group did not have a consensus. | ||
| 2. Fragment-only identifiers (without a URL) should allow inline `@sheet` references on the same document to be included globally (even within shadow roots). This wasn't brought up in the CSSWG discussions at all, but is important for DSD without requiring an external file (to avoid FOUC). | ||
| 3. Behavior of `@import` - should `@import` be possible within `@sheet` at all, should it be allowed if it's the first/only statement, or should it be blocked? There was discussion of this in the CSSWG, but no conclusion was reached. This was briefly discussed in this CSSWG conversation: https://lists.w3.org/Archives/Public/www-style/2023Apr/0004.html | ||
| 4. What happens with multiple `@sheet` definitions with the same identifier? First-definition wins, or do they get merged like `@layer`? Again, this was brought up in the CSSWG but not resolved. Note that it's possible to have a "Flash of other-styled content" if it's last-defintion-wins, as the first definition may apply, then a later definition from an external CSS file may override it. |
There was a problem hiding this comment.
Should we link to where this was brought up in the CSSWG?
| <span>I'm in the light DOM</span> | ||
| ``` | ||
| 6. The name `nestedStyleSheets` is up for discussion. | ||
| 7. Should we add `name` to the `StyleSheet` interface or overload the existing `title` attribute instead? |
There was a problem hiding this comment.
nit: extra space before "overload"
dandclark
approved these changes
Jan 14, 2025
|
|
||
| sheet.css: | ||
|
|
||
| ```html |
There was a problem hiding this comment.
Suggested change
| ```html | |
| ```css |
| sheet.css: | ||
|
|
||
| ```html | ||
| @sheet foo { |
There was a problem hiding this comment.
The CSS here doesn't seem to be valid. Was it meant to be this?
@sheet foo {
div {
color: red;
}
}
div {
color: blue;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of looking at Declarative CSS Modules, TAG has suggested that we should investigate
@sheetas a possible direction. This explainer summarizes and builds on the CSSWG discussion about this idea to consolidate it into a single location.