Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: send to contract address #9710

Closed
wants to merge 43 commits into from
Closed

test: send to contract address #9710

wants to merge 43 commits into from
+99 −21

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented May 21, 2024 •
edited
Loading

Description

As the PR title says, this PR adds e2e coverage for sending to a contract address.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels May 21, 2024
@cortisiko cortisiko self-assigned this May 21, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 23aaa82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4842c819-6fd0-45e6-bc22-f7421d9eb1cd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5b99d94
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccc6e75f-2b4c-4d14-91df-e05c72f36899

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko removed the Run Smoke E2E Triggers smoke e2e on Bitrise label May 21, 2024
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0c1ad8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/872eef3f-9e85-4ed5-87a6-7aac0a5b074d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 822a01c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/128f3564-a04d-476b-85ea-683911457c18

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dd80313
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc8f75bf-c720-41d0-82a6-62ae8f4918cc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fdf1f03
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/96d12b64-093d-44bb-8641-004444079c75

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f16d15d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d770108e-2cd2-4127-9a09-88fdfe81e62a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko closed this Aug 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@cortisiko cortisiko reopened this Dec 18, 2024
@cortisiko cortisiko closed this Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox left review comments

Assignees

@cortisiko cortisiko

Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cortisiko @codecov-commenter @chrisleewilcox