Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump crypto js to 4.2.0 #7614

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 26, 2023

Description

Bumping crypto js to 4.2.0 on all dependencies of the project

Does not seem any package had a crypto js dependency by looking at yarn.lock
Probably other approach instead of had the resolution it is to delete the version yarn.lock directly.

E2E

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0bde23a6-f00e-4268-9ce8-9b3feda5de54

Manual testing steps

Related issues

Screenshots/Recordings

The recordings include as well changing network

Goerli transaction: https://recordit.co/HXGNfr9gPQ
Swap ethereum mainnet: https://recordit.co/5hg24OJEjc
Swap Avalanche mainnet: https://recordit.co/XMSFtdNCbF

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner October 26, 2023 10:11
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Oct 26, 2023
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
crypto-js 4.1.1...4.2.0 None +0/-0 487 kB evanvosberg

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af2a404) 34.85% compared to head (92adf7b) 34.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7614   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files        1027     1027           
  Lines       27423    27423           
  Branches     2267     2267           
=======================================
  Hits         9558     9558           
  Misses      17355    17355           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 26, 2023
@tommasini tommasini added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 26, 2023
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 26, 2023
@tommasini tommasini merged commit 9a31999 into main Oct 26, 2023
44 of 47 checks passed
@tommasini tommasini deleted the fix/audit-issue-GHSA-xwcq-pm8m-c4vf branch October 26, 2023 14:46
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants