Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy changes, Security advice by > Powered by #7603

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Oct 25, 2023

Description

Problem: In Extension we show Powered by Blockaid wheres in Mobile we show Security advice by Blockaid.
Should we consolidate this into the same message? cc @bschorchit

Expected behavior

Show Powered by in mobile too

Related issues

Fixes: #7515

Manual testing steps

  1. Enable Blockaid
  2. Go to the test dapp
  3. Trigger a malicious signature
  4. See text

Screenshots/Recordings

Before

Screenshot from 2023-10-16 13-07-24

After

Screenshot 2023-10-25 at 13 47 11

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team labels Oct 25, 2023
@segun segun self-assigned this Oct 25, 2023
@segun segun requested a review from a team as a code owner October 25, 2023 12:49
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55848ab) 34.66% compared to head (fd76c1f) 34.66%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7603   +/-   ##
=======================================
  Coverage   34.66%   34.66%           
=======================================
  Files        1023     1023           
  Lines       27345    27344    -1     
  Branches     2242     2242           
=======================================
  Hits         9478     9478           
+ Misses      17369    17368    -1     
  Partials      498      498           
Files Coverage Δ
app/components/Views/BrowserTab/index.js 2.55% <ø> (ø)
app/lib/ens-ipfs/resolver.js 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segun
Copy link
Contributor Author

segun commented Oct 25, 2023

@segun segun merged commit 2f1ddbd into main Oct 25, 2023
30 checks passed
@segun segun deleted the olu/blockaid-powered-by-copy-change branch October 25, 2023 20:24
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Security Advice vs Powered by discrepancy between platforms
5 participants