Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Scope PortfolioView feature flag to iOS devices only #13039

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

gambinish
Copy link
Contributor

Description

Scopes the PortfolioView feature flag to only be true for iOS devices, while we do more troubleshooting on the performance bottleneck on Android devices.

Related issues

Performance related bug ticket: #12679

Manual testing steps

  1. Run app with feature flag: PORTFOLIO_VIEW='true' yarn watch:clean
  2. On iOS device, PortfolioView should be enabled
  3. On Android device, PortfolioView should not be enabled

Screenshots/Recordings

Screenshot 2025-01-16 at 11 31 49 AM Screenshot 2025-01-16 at 11 35 57 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review January 16, 2025 19:40
@gambinish gambinish requested a review from a team as a code owner January 16, 2025 19:40
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 961f73e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b5de7004-2fe7-4dae-a833-70536ac82218

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gambinish gambinish added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 7f8d095 Jan 16, 2025
44 of 47 checks passed
@gambinish gambinish deleted the feat/scope-pv-to-ios-release branch January 16, 2025 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants