Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: erc 1155 batch transfer #12800

Merged
merged 3 commits into from
Dec 20, 2024
Merged

test: erc 1155 batch transfer #12800

merged 3 commits into from
Dec 20, 2024

Conversation

C-Ivan
Copy link
Contributor

@C-Ivan C-Ivan commented Dec 19, 2024

Description

This PR is within the scope of the Quality Quest.

We're including an e2e test case to check the batch transfer for ERC1155 in test dApp.

Steps:
Given I am on the test dapp
When I tap on the batch transfer button in the ERC-1155 section
Then the contract bottom sheet should appear
When I submit the transaction
Then the transaction should appear in the transaction history

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Dec 19, 2024
@C-Ivan C-Ivan self-assigned this Dec 19, 2024
@C-Ivan C-Ivan added No QA Needed Apply this label when your PR does not need any QA effort. e2e-test team-confirmations Push issues to confirmations team labels Dec 19, 2024
@C-Ivan C-Ivan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed e2e-test labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 37cffe1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bcae1d49-4719-4e2a-8fdc-5342317258c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@C-Ivan C-Ivan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@C-Ivan C-Ivan marked this pull request as ready for review December 19, 2024 22:01
@C-Ivan C-Ivan requested a review from a team as a code owner December 19, 2024 22:01
@C-Ivan C-Ivan added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit c7eee9c Dec 20, 2024
44 checks passed
@C-Ivan C-Ivan deleted the detox/erc-1155-batch-transfer branch December 20, 2024 13:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants