Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix swap flow #12788

Merged
merged 10 commits into from
Dec 19, 2024
Merged

fix: fix swap flow #12788

merged 10 commits into from
Dec 19, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Dec 19, 2024

Description

Related issues

Fixes: #12757

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

fixed.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/fix-swap-flow branch from 7af93ad to f8be670 Compare December 19, 2024 11:11
@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Dec 19, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Dec 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.03%. Comparing base (9d6908b) to head (8fb21a5).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/Asset/index.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12788      +/-   ##
==========================================
+ Coverage   58.85%   59.03%   +0.17%     
==========================================
  Files        1851     1851              
  Lines       41739    41755      +16     
  Branches     5397     5399       +2     
==========================================
+ Hits        24566    24648      +82     
+ Misses      15502    15438      -64     
+ Partials     1671     1669       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@salimtb salimtb marked this pull request as ready for review December 19, 2024 13:01
@salimtb salimtb requested a review from a team as a code owner December 19, 2024 13:01
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8fb21a5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/168e4a8f-ad56-470c-9af6-ba0361f3624d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 203f6f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d9734a95-1f53-4855-9ed1-2a12f4e931c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sahar-fehri
sahar-fehri previously approved these changes Dec 19, 2024
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@salimtb salimtb requested a review from sahar-fehri December 19, 2024 14:45
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f9a291b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea7da375-bb7f-42c3-8d3a-2597e0107432

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 9708fe6 Dec 19, 2024
39 of 40 checks passed
@salimtb salimtb deleted the salim/fix-swap-flow branch December 19, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Swap button hidden for non current network
4 participants