Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable confirmations e2e #12750

Merged

Conversation

cortisiko
Copy link
Member

Description

The security-alert-send-eth.mock.spec.js started failing during quality week. Since most of the team is focused on their respective quality initiatives, this specific e2e test will be addressed once capacity allows. To prevent engineers from repeatedly running tests in an attempt to pass the pipeline, which could push us over our build quota, I’m temporarily disabling this e2e test.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@cortisiko cortisiko self-assigned this Dec 18, 2024
@cortisiko cortisiko requested a review from a team as a code owner December 18, 2024 04:11
Copy link
Contributor

github-actions bot commented Dec 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e1304d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6f43dc84-e587-46c3-a8da-30e7f7fcbe69

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko enabled auto-merge December 18, 2024 04:16
@cortisiko cortisiko added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit a6b0197 Dec 18, 2024
45 checks passed
@cortisiko cortisiko deleted the detox/temporarily-disable-confirmations-security-e2e branch December 18, 2024 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants