Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch mantle price fix #29790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jan 17, 2025

Description

PR to patch Mantle price core fix

current Mantle price: https://www.cryptocompare.com/coins/mantle/overview/USDC

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Add Mantle network from chainList (chainId 5000)
  2. Go to MM and you should see correct fiat balance

Screenshots/Recordings

Before

Screenshot 2025-01-17 at 21 18 51

After

Screenshot 2025-01-17 at 21 17 08

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jan 17, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review January 17, 2025 20:20
@metamaskbot
Copy link
Collaborator

Builds ready [5cec1ce]
Page Load Metrics (1612 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14461851161211555
domContentLoaded14371796158610450
load14551866161211857
domInteractive247441178
backgroundConnect583272512
firstReactRender1575372411
getState439984
initialActions01000
loadScripts1047137311678943
setupStore65816188
uiStartup16722242184615575
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 38 Bytes (0.00%)
  • common: 312 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants