refactor: make sure to use static constant variables for accounts in fixture-builder.js

[ffmcgee725]

-- refactor: make sure to use static constant variables for accounts in fixture-builder.js;

Description

Related issues

Fixes:

Manual testing steps

1. Run E2E tests
2. Should pass after change introduced

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[Gudahtt]

LGTM!

[adonesky1]

LGTM!

[Gudahtt]

Ah, this import is causing problems. It seems that this file is being pulled into the build somehow, and adding this import is resulting in some environment variables being referenced that are not defined, causing a build failure.

Why is this part of the build 🤔

[Gudahtt]

We could resolve the error by moving these account constants from helpers to a constants file. That will ensure no additional environment variable references are brought in.

But this file being in the application bundle seems like a mistake.

[ffmcgee725]

Did suggested change in 73b8c72 🤞🏾

Build errors