Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove scroll to bottom requirement for signatures #29784

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Jan 17, 2025

Description

Removes scroll to bottom requirement on signatures
Improves the clickElementSafe function

Open in GitHub Codespaces

Related issues

Fixes: #29779

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner January 17, 2025 14:29
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 17, 2025
@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner January 17, 2025 14:30
@metamaskbot
Copy link
Collaborator

Builds ready [4a1f897]
Page Load Metrics (1714 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15371881171110751
domContentLoaded15291861168710751
load15381874171410651
domInteractive26129502512
backgroundConnect57322189
firstReactRender1585462713
getState56217199
initialActions01000
loadScripts1092136612479244
setupStore65110105
uiStartup16742114192811756
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner January 17, 2025 15:46
@pnarayanaswamy pnarayanaswamy changed the title test: Increases element location timeout for snaps test fix: Remove scroll to bottom requirement for signatures Jan 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3af4f92]

@metamaskbot
Copy link
Collaborator

Builds ready [e90cce5]
Page Load Metrics (1619 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53821961558281135
domContentLoaded14122139158914469
load14302193161915373
domInteractive238238157
backgroundConnect56625199
firstReactRender1598373014
getState574192211
initialActions01000
loadScripts10151604116111957
setupStore67114178
uiStartup160924821933258124
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -88 Bytes (-0.00%)
  • ui: -462 Bytes (-0.01%)
  • common: -32 Bytes (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Test Snap ethereum_provider can use the ethereum_pro..." flaky tests
3 participants