Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix for lint error on v12.11.0 #29770

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

benjisclowder
Copy link
Contributor

@benjisclowder benjisclowder commented Jan 17, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [ff8645a]
Page Load Metrics (1566 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31118881452364175
domContentLoaded13551876153312560
load13631886156613665
domInteractive23161463115
backgroundConnect497332512
firstReactRender1490362612
getState45512147
initialActions01000
loadScripts9671487113512861
setupStore584142110
uiStartup157324071849245118

@benjisclowder benjisclowder merged commit 5eb2566 into Version-v12.11.0 Jan 17, 2025
71 checks passed
@benjisclowder benjisclowder deleted the fix-lint-error branch January 17, 2025 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants