Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove unused restrictReturnedAccounts param option #29767

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 16, 2025

Description

  • Removes the restrictReturnedAccounts param option in many of the fixtures for eth_accounts in the fixture builder since it is no longer used anywhere

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi marked this pull request as ready for review January 16, 2025 22:57
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [c5d15e8]
Page Load Metrics (1774 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24528181552610293
domContentLoaded135427681736300144
load142528151774293141
domInteractive22104422010
backgroundConnect10144363115
firstReactRender1598503416
getState697222713
initialActions01000
loadScripts96821081290244117
setupStore64913136
uiStartup161731072115325156
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -50 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 8ac2116 Jan 16, 2025
78 checks passed
@jiexi jiexi deleted the jl/remove-restrictReturnedAccounts-fixture branch January 16, 2025 23:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants